[PATCH] D19949: test_suite: Add a --just-submit flag and mode

[James Molloy via llvm-commits]

Hi Matthias,

Thinking about this, perhaps this functionality should be added at a higher
level. LNT currently understands and can convert two formats: plist and
JSON. Perhaps we should add the LIT JSON as a third type, that can be
upgraded to the LNT JSON (with lnt convert, or lnt submit could do it
transparently?)

The caveat would be that it would need to introspect the system as is done
in builtintest.py so must be done on the system in question, but this
doesn't sound unreasonable. This approach is similar to the one I've taken
in the profiling infrastructure for importing/upgrading Linux Perf reports
to the LNT profile format.

What do you think?

Cheers,

James

On Thu, 5 May 2016 at 02:24 Matthias Braun via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> MatzeB added a comment.
>
> In http://reviews.llvm.org/D19949#421849, @cmatthews wrote:
>
> > I agree with the updated test parsing logic, that is much better.
> >
> > This flag seems to be redundant to the "lnt submit" feature which is
> supposed to do exactly the same thing.  I would guess that does not work
> with the lit json directly though?  It seems to me that would be a better
> place for this functionality, otherwise we have lnt runtest test-suite
> --just-submit <json> and lnt submit <json> which do the same thing to
> different kinds of json files.
>
>
> Yes that sounds like the better approach in terms of usability. I just
> have to find a way to refactor this because it currently relies on some
> code from test-suite.py/builtintest.py to fill in some information about
> the compiler and run orders which isn't available in the lit output.
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D19949
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160505/51001d5e/attachment.html>