[PATCH] D19949: test_suite: Add a --just-submit flag and mode

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Wed May 4 18:24:15 PDT 2016


MatzeB added a comment.

In http://reviews.llvm.org/D19949#421849, @cmatthews wrote:

> I agree with the updated test parsing logic, that is much better.
>
> This flag seems to be redundant to the "lnt submit" feature which is supposed to do exactly the same thing.  I would guess that does not work with the lit json directly though?  It seems to me that would be a better place for this functionality, otherwise we have lnt runtest test-suite --just-submit <json> and lnt submit <json> which do the same thing to different kinds of json files.


Yes that sounds like the better approach in terms of usability. I just have to find a way to refactor this because it currently relies on some code from test-suite.py/builtintest.py to fill in some information about the compiler and run orders which isn't available in the lit output.


Repository:
  rL LLVM

http://reviews.llvm.org/D19949





More information about the llvm-commits mailing list