[PATCH] D18216: [Support] Creation of minidump after compiler crash on Windows

[Leny Kholodov via llvm-commits]

lenykholodov added inline comments.

================
Comment at: lib/Support/Windows/Signals.inc:124
@@ -119,1 +123,3 @@
 
+typedef BOOL(WINAPI *fpMiniDumpWriteDump)(HANDLE, DWORD, HANDLE, MINIDUMP_TYPE,
+                                          PMINIDUMP_EXCEPTION_INFORMATION,
----------------
aaron.ballman wrote:
> lenykholodov wrote:
> > I have checked llvm support building with mingw and have not found any issues. Could you please clarify what is wrong with this code?
> The code is fine, I just wish we didn't have to dynamically load everything and redeclare things from public SDKs. I should have been more clear, sorry about that! There's nothing for you to change here, more of a note that we should see whether we still need to continue following this pattern for MinGW.
Thank you for clarification


Repository:
  rL LLVM

http://reviews.llvm.org/D18216