[PATCH] D18216: [Support] Creation of minidump after compiler crash on Windows

[Aaron Ballman via llvm-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

Thank you for working on this, the patch LGTM!


================
Comment at: lib/Support/Windows/Signals.inc:124
@@ -119,1 +123,3 @@
 
+typedef BOOL(WINAPI *fpMiniDumpWriteDump)(HANDLE, DWORD, HANDLE, MINIDUMP_TYPE,
+                                          PMINIDUMP_EXCEPTION_INFORMATION,
----------------
lenykholodov wrote:
> I have checked llvm support building with mingw and have not found any issues. Could you please clarify what is wrong with this code?
The code is fine, I just wish we didn't have to dynamically load everything and redeclare things from public SDKs. I should have been more clear, sorry about that! There's nothing for you to change here, more of a note that we should see whether we still need to continue following this pattern for MinGW.

================
Comment at: lib/Support/Windows/Signals.inc:611
@@ +610,3 @@
+
+  SmallVector<wchar_t, MAX_PATH> Buffer(BufferLengthBytes);
+
----------------
lenykholodov wrote:
> This was done similar to using of SmallVector in Path.inc file. I can change type to std::vector. However, this will be inconsistent with other code in Support library.
Consistency is reasonable enough, the SmallVector can handle being not small and this isn't on a hot code path, so I think it's fine as-is.


Repository:
  rL LLVM

http://reviews.llvm.org/D18216