[PATCH] D19825: Power9 - Add exploitation of vector load and store that do not require swaps

[Nemanja Ivanovic via llvm-commits]

nemanjai added inline comments.

================
Comment at: lib/Target/PowerPC/InstPrinter/PPCInstPrinter.cpp:36
@@ -35,1 +35,3 @@
 
+// Useful for testing purposes. Prints vs{31-63} as v{0-31} respectivelly.
+static cl::opt<bool>
----------------
wschmidt wrote:
> nemanjai wrote:
> > If there are objections to adding this, I'm happy to remove it. The reason I added it is that I find it frustrating that I can't specify FileCheck patterns that ensure that a VSX instruction's result is the correct operand of a VMX instruction and vice-versa.
> > 
> > I could also wrap this in an
> >   #ifndef _NDEBUG
> > block, but then we would have to ensure that test cases that use it somehow require LLVM Asserts.
> I'm agnostic about that; however, you should remove the extra "l" from "respectively." :)
:) I think I need the little red squiggly line in Vim.

================
Comment at: lib/Target/PowerPC/PPCInstrInfo.cpp:1012
@@ -1008,1 +1011,3 @@
+      Op = PPC::STXVX;
+    NewMIs.push_back(addFrameReference(BuildMI(MF, DL, get(Op))
                                        .addReg(SrcReg,
----------------
wschmidt wrote:
> Could use ternary operator here.
Will do. I noticed that the if is quite extraneous here after I posted the patch.


Repository:
  rL LLVM

http://reviews.llvm.org/D19825