[PATCH] D19742: [CMake] Support platform building builtins without a full toolchain

[Jonathan Roelofs via llvm-commits]

jroelofs added inline comments.

================
Comment at: cmake/base-config-ix.cmake:24
@@ +23,3 @@
+         ${LLVM_INCLUDE_TESTS})
+ option(COMPILER_RT_ENABLE_WERROR "Fail and stop if warning is triggered"
+        ${LLVM_ENABLE_WERROR})
----------------
indentation is wrong here.

================
Comment at: cmake/config-ix.cmake:218
@@ -312,6 +217,3 @@
     set(DARWIN_watchos_SANITIZER_MIN_VER_FLAG
-      ${DARWIN_watchos_MIN_VER_FLAG}=2.0)
-    set(DARWIN_watchos_BUILTIN_MIN_VER 2.0)
-    set(DARWIN_watchos_BUILTIN_MIN_VER_FLAG
-      ${DARWIN_watchos_MIN_VER_FLAG}=${DARWIN_watchos_BUILTIN_MIN_VER})
+      ${DARWIN_watchos_MIN_VER_FLAG}=1.0)
   endif()
----------------
was bumping the min version here intentional?

================
Comment at: lib/builtins/CMakeLists.txt:18
@@ -17,3 +35,2 @@
   addvti3.c
-  apple_versioning.c
   ashldi3.c
----------------
why did this get deleted?


http://reviews.llvm.org/D19742