[lld] r268093 - Fix some Include What You Use warnings; other minor fixes.

[David Blaikie via llvm-commits]

On Fri, Apr 29, 2016 at 3:54 PM, Eugene Zelenko via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Hi, David!
>
> On Fri, Apr 29, 2016 at 3:49 PM, David Blaikie <dblaikie at gmail.com> wrote:
> >
> >
> > On Fri, Apr 29, 2016 at 12:47 PM, Eugene Zelenko via llvm-commits
> > <llvm-commits at lists.llvm.org> wrote:
> >>
> >> -}
> >> +} // end namespace lld
> >
> > Do we have any significantly prevailing style for end of namespace
> comments?
> > (does the style guide say we should have them? Do we usually use "end
> blah"
> > rather than just "blah", etc) - I'd be a bit surprised. & if we don't,
> I'd
> > hesitate to do any cleanup like this.
>
> There are Clang-tidy check for LLVM end of namespace comments
> (http://clang.llvm.org/extra/clang-tidy/checks/llvm-namespace-comment.html
> )
>
> But as far as I know there is no agreement on what it should be. I
> encountered a lot comments with "end" in LLVM headers, so I use this
> particular style.
>

Sure - that's a fine motivation for any code you write in LLVM - but not
sure it's necessary/appropriate to change existing comments in code you
aren't working on otherwise.

A check that could correct /incorrect/ ending comments might be handy (if
someone uses the wrong namespace name, for example), but unless we've got a
pretty clear goal/style guide/buy in I think it's best not to go around
doing mass cleanups as yet.

- David


>
> Eugene.
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160429/f28f7e43/attachment.html>