[lld] r268093 - Fix some Include What You Use warnings; other minor fixes.

Eugene Zelenko via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 29 15:54:55 PDT 2016


Hi, David!

On Fri, Apr 29, 2016 at 3:49 PM, David Blaikie <dblaikie at gmail.com> wrote:
>
>
> On Fri, Apr 29, 2016 at 12:47 PM, Eugene Zelenko via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>>
>> -}
>> +} // end namespace lld
>
> Do we have any significantly prevailing style for end of namespace comments?
> (does the style guide say we should have them? Do we usually use "end blah"
> rather than just "blah", etc) - I'd be a bit surprised. & if we don't, I'd
> hesitate to do any cleanup like this.

There are Clang-tidy check for LLVM end of namespace comments
(http://clang.llvm.org/extra/clang-tidy/checks/llvm-namespace-comment.html)

But as far as I know there is no agreement on what it should be. I
encountered a lot comments with "end" in LLVM headers, so I use this
particular style.

Eugene.


More information about the llvm-commits mailing list