[PATCH] D19636: [ThinLTO] Add option to emit imports files for distributed backends

[Mehdi AMINI via llvm-commits]

joker.eph added a comment.



> > Actually I have the impression that the gold-plugin is getting too fat: these functionality should be abstracted in LLVM an not be implemented here.

> 

> 

> I could move this particular code into a helper in FunctionImport.cpp that takes in the ImportsLists and a file name as input, and do the file I/O there.

>  (Unrelated to this patch, but to the above comment: as noted in my response to http://reviews.llvm.org/D19556 this morning, I will pull the preceding code to compute the ModuleToSummariesForIndexMap into a helper in FunctionImport.cpp.)


Yes this is not about this patch in particular, this is about this plugin file that drifted over time. Its scope should be very narrowed to the interaction with gold IMO. All other logic should be refactored in some LLVM libraries.


http://reviews.llvm.org/D19636