[PATCH] D19636: [ThinLTO] Add option to emit imports files for distributed backends

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 28 09:20:05 PDT 2016


tejohnson added a comment.

In http://reviews.llvm.org/D19636#415046, @joker.eph wrote:

> It'd be nice to have this mirrored in llvm-lto.


I will do that and add a test.

> Actually I have the impression that the gold-plugin is getting too fat: these functionality should be abstracted in LLVM an not be implemented here.


I could move this particular code into a helper in FunctionImport.cpp that takes in the ImportsLists and a file name as input, and do the file I/O there.
(Unrelated to this patch, but to the above comment: as noted in my response to http://reviews.llvm.org/D19556 this morning, I will pull the preceding code to compute the ModuleToSummariesForIndexMap into a helper in FunctionImport.cpp.)


http://reviews.llvm.org/D19636





More information about the llvm-commits mailing list