[PATCH] D19645: Skip scanRelocs for non-alloc sections.

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/InputSection.h:222
@@ +221,3 @@
+  template <class RelTy>
+  void relocateNative(uint8_t *Buf, llvm::ArrayRef<RelTy> Rels);
+
----------------
rafael wrote:
> Native?
Do you have any suggestions for better name?

================
Comment at: test/ELF/relocation-non-alloc.s:36
@@ -35,3 +35,3 @@
 // CHECK-NEXT: SectionData (
-// CHECK-NEXT:   0000: 00100000 00000000 00000000 00000000
+// CHECK-NEXT:   0000: 00100000 00000000 00100000 00000000
 // CHECK-NEXT: )
----------------
rafael wrote:
> Is the change expected?
Yes. BFD and gold both produces this pattern rather than the old one. This is a test to produce a DSO file with a non-alloc section pointing to an interruptible symbol. This seems to be unrealistic test case. LLD previously handle interruptible symbols addresses as 0 because it can change at runtime, but GNU linkers don't seem to bother it.


http://reviews.llvm.org/D19645