[PATCH] D19645: Skip scanRelocs for non-alloc sections.

[Rafael Ávila de Espíndola via llvm-commits]

rafael added a comment.

I really like this. It is a lot simpler than what I was expecting.
But why the test changed?


================
Comment at: ELF/InputSection.h:222
@@ +221,3 @@
+  template <class RelTy>
+  void relocateNative(uint8_t *Buf, llvm::ArrayRef<RelTy> Rels);
+
----------------
Native?

================
Comment at: ELF/Writer.cpp:535
@@ -534,3 +534,3 @@
   uintX_t Flags = C.getSectionHdr()->sh_flags;
   bool IsAlloc = Flags & SHF_ALLOC;
   bool IsWrite = Flags & SHF_WRITE;
----------------
This is now always false.

================
Comment at: test/ELF/relocation-non-alloc.s:36
@@ -35,3 +35,3 @@
 // CHECK-NEXT: SectionData (
-// CHECK-NEXT:   0000: 00100000 00000000 00000000 00000000
+// CHECK-NEXT:   0000: 00100000 00000000 00100000 00000000
 // CHECK-NEXT: )
----------------
Is the change expected?


http://reviews.llvm.org/D19645