[PATCH] D18831: [Coverage] Use the count value of the outer region for an expansion region.

Igor Kudrin via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 26 09:43:53 PDT 2016


ikudrin added a comment.

In http://reviews.llvm.org/D18831#411576, @davidxl wrote:

> The code looks correct, but after a second though, I wonder if the logic in 
> fixExpansionRegion
>
> should really be done in Clang: tools/clang/lib/CodeGen/CoverageMappingGen.cpp
>
> The counter expression for the expansion region should really be the counter of the enclosing region, instead of 'enclosing region counter + ....'.


Thanks! Sounds reasonable, I'll see if the issue can be fixed there.


http://reviews.llvm.org/D18831





More information about the llvm-commits mailing list