[PATCH] D18831: [Coverage] Use the count value of the outer region for an expansion region.

David Li via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 25 17:40:35 PDT 2016


davidxl added a comment.

The code looks correct, but after a second though, I wonder if the logic in 
fixExpansionRegion

should really be done in Clang: tools/clang/lib/CodeGen/CoverageMappingGen.cpp

The counter expression for the expansion region should really be the counter of the enclosing region, instead of 'enclosing region counter + ....'.


http://reviews.llvm.org/D18831





More information about the llvm-commits mailing list