[PATCH] D19410: [scan-build] fix logic error warnings emitted on llvm code base
Tom Stellard via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 25 07:07:29 PDT 2016
tstellarAMD added inline comments.
================
Comment at: lib/Target/AMDGPU/SIInstrInfo.cpp:1839
@@ +1838,3 @@
+ // This operand expects an immediate.
+ return true;
+ }
----------------
Looking at this again. I think this should return !MO.isReg() and it should be moved below
if (!MO)
MO = &MI->getOperand(OpIdx);
Sorry I missed this the first time.
http://reviews.llvm.org/D19410
More information about the llvm-commits
mailing list