[PATCH] D19236: Add DITypeIndex for CodeView and emit it for locals

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 21 15:09:16 PDT 2016


On Thu, Apr 21, 2016 at 2:31 PM, Aboud, Amjad <amjad.aboud at intel.com> wrote:

> I am not convinced that you are going the right direction.
>
Can we chat about it via VC perhaps? I have already explained once why I
think this is the right way to go, and you remain unconvinced:
http://lists.llvm.org/pipermail/llvm-dev/2016-March/096624.html

> Not only that, now you are confusing me with the double motivation, I
> asked you before on the proposal of improving debug info if the motivation
> was CodeView and you said “no”.
>
> Now, you claim that the motivation is fast implementation for CodeView.
>
I think it is easier/faster/doable to emit CodeView from current Dwarf
> Metadata, for sure more than you will be able to do with the
> Blobs/MDStrings that you do not explain yet how it will look like.
>
It's not important to me how fast or easy it is to implement this support
today. Neither approach is particularly technically challenging. My
priority is low maintenance costs and reasonable performance in the long
run.

> I can simply let you commit this patch that adds nothing to what we can do
> today, but you will need to prove that the next patch (when you support
> compound types) will work more than we can implement today with what we
> have in dwarf.
>
> If your approach will fail, will you consider revert and go back to one
> representation of debug info (Dwarf based or whatever) and do the simple
> extra work in the backend to emit the format needed by the target?
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160421/dcd75b35/attachment.html>


More information about the llvm-commits mailing list