[PATCH] D17503: [MSAN] Mark dlerror.cc expected failure for MIPS

Evgeniy Stepanov via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 18 13:45:37 PDT 2016


eugenis added a comment.

Thank you for the investigation!
We already have what you describe as "__msan_in_libcall". It's called MSanInterceptorContext::in_interceptor_scope and ::in_interceptor_scope in msan_interceptors.cc. At the moment it applies to the common interceptors, but not to msan-specific interceptors; dlerror is msan-specific.
I think it would be a good idea to extend the MsanInterceptorContext logic from COMMON_INTERCEPTOR_ENTER to all the (legacy) msan interceptors. Among other things, this would make ENSURE_MSAN_INITED() and "if (msan_init_is_running)" lines in most interceptors unnecessary.


Repository:
  rL LLVM

http://reviews.llvm.org/D17503





More information about the llvm-commits mailing list