[PATCH] D19190: [ELF] - Implemented PROVIDE linker script command.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 21 14:36:37 PDT 2016


ruiu added inline comments.

================
Comment at: ELF/LinkerScript.h:52-55
@@ +51,6 @@
+// * SectionKind is a description of output section, like ".data :..."
+// * ContentKind is a content of output section, it helps to distinguish PROVIDE
+//   command before and after section content, first one should have address
+//   equal to address of output section, second points to location after that.
+// * ProvideKind is PROVIDE command.
+enum SectionsCommandKind { ExprKind, SectionKind, ContentKind, ProvideKind };
----------------
If it is currently hard to do to process PROVIDE command as we assign addresses to sections, then something is not right. The way we represent SECTIONS subcommands are probably inappropriate. Building a feature on top of the data structure will things more complicated. I'll fix this first.


http://reviews.llvm.org/D19190





More information about the llvm-commits mailing list