[PATCH] D19190: [ELF] - Implemented PROVIDE linker script command.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 21 08:55:06 PDT 2016


grimar added a comment.

In http://reviews.llvm.org/D19190#407852, @Wallbraker wrote:

> As I was reading this patch and comments I had some concerns about the different behavior between bfd and gold and that error messages would not provide enough information. The patch seem to address these concern so I'm happy with this patch.
>
> Since I know too little about the lld source I don't dare to accept revision. But thanks for the great work!
>
> PS: My use case for linker scripts is hobby osdev.


Thanks for feedback ! For usual errors in script we already report script line + column (http://reviews.llvm.org/D18699),
I think one day we will connect that error reporting system with expression evaluations code somehow, so
finding errors will be easier.


http://reviews.llvm.org/D19190





More information about the llvm-commits mailing list