[PATCH] D19168: [esan] EfficiencySanitizer base runtime library

[Derek Bruening via llvm-commits]

bruening marked 4 inline comments as done.

================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:35
@@ -33,1 +34,3 @@
+// COMMON_INTERCEPTOR_ON_EXIT is only called if the app explicitly calls exit(),
+// not on a normal exit.
 //===----------------------------------------------------------------------===//
----------------
filcab wrote:
> The problem is that later, when blaming that file, people will see this commit, and possibly spend time looking at it because of an unrelated change.
> I'm totally ok with adding the comment, I think it's useful. But I don't think it belongs to the "Introduce ESan" commit.
Oh, I misread "to a separate commit" as "to a separate comment".


http://reviews.llvm.org/D19168