[PATCH] D19168: [esan] EfficiencySanitizer base runtime library

[Derek Bruening via llvm-commits]

bruening added inline comments.

================
Comment at: lib/esan/esan_interface_internal.h:30
@@ +29,3 @@
+typedef enum Type {
+  ESAN_None = 0,
+  ESAN_CacheFrag,
----------------
filcab wrote:
> No. It was more about fixing the underlying type:
> http://en.cppreference.com/w/cpp/language/enum
> Version (2) of "Unscoped enumeration".
That is on the list of C++11 allowed in LLVM, but putting it inside the extern "C" feels wrong (hence why it seemed the only solution was what I mentioned).  I suppose it's fine if there is no C program that includes the header, which is the case if we are able to remove the ifdef __cplusplus.


http://reviews.llvm.org/D19168