[PATCH] D19096: ModuleLinker: do not always pull-in linkonce_odr when performing ThinLTO importing

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 19 18:10:24 PDT 2016


joker.eph added inline comments.

================
Comment at: lib/Transforms/IPO/FunctionImport.cpp:169
@@ -168,2 +168,3 @@
           &cast<AliasSummary>(CalleeSummary)->getAliasee());
-    else
+      if (!GlobalValue::isLinkOnceODRLinkage(ResolvedCalleeSummary->linkage())) {
+        // Alias can't point to "available_externally". However when we import
----------------
tejohnson wrote:
> The fix to move this check here instead of being later in importFunctions() seems independent from the rest of this patch - can/should it be committed separately?
r266845


http://reviews.llvm.org/D19096





More information about the llvm-commits mailing list