[PATCH] D19096: ModuleLinker: do not always pull-in linkonce_odr when performing ThinLTO importing

[Teresa Johnson via llvm-commits]

tejohnson added inline comments.

================
Comment at: tools/llvm-link/llvm-link.cpp:280
@@ +279,3 @@
+    // Instruct the linker to not automatically import linkonce defintion.
+    unsigned Flags = Linker::Flags::DontForceLinkLinkonceODR;
+
----------------
joker.eph wrote:
> tejohnson wrote:
> > Doesn't the ODR resolution need to be done to set this flag? I don't see it being done in llvm-link.
> I'm not sure what you'd see to resolve here, this is the mode where llvm-link is instructed on the command line to import a specific list of functions.
Ah yes, nevermind. Just the other two comments/questions then.


http://reviews.llvm.org/D19096