[PATCH] D19190: [ELF] - Implemented PROVIDE linker script command.

[Ed Maste via llvm-commits]

emaste added a subscriber: emaste.
emaste added a comment.

> First will be incompatible with some existing bsd scripts, for example:

>  https://svnweb.freebsd.org/base/head/sys/conf/ldscript.amd64?view=markup

>  It has

>  PROVIDE (start_ctors = .);

>  ..

>  PROVIDE (stop_ctors = .);

>  declared outside output sections definition. 

>  Would it be acceptable to require that ?


In the case of (at least) `start_ctors` and `stop_ctors` the script the script is more clear with them inside of the `.ctors : { }` so it's reasonable for FreeBSD to move them.

I do wonder how common this will be in practice across arbitrary 3rd party software (that does not have a vested interest in linking with lld), but it seems reasonable to proceed with Rafael's suggestion for now and revisit later if necessary.


http://reviews.llvm.org/D19190