[PATCH] D19190: [ELF] - Implemented PROVIDE linker script command.
Rui Ueyama via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 19 10:31:08 PDT 2016
ruiu added inline comments.
================
Comment at: ELF/LinkerScript.cpp:132-135
@@ +131,6 @@
+ if (Cmd.Kind == ProvideKind) {
+ auto I = ElfSym<ELFT>::Provide.find(Cmd.Name);
+ if (I != ElfSym<ELFT>::Provide.end())
+ I->second->Value = evaluate(Cmd.Expr, VA);
+ continue;
+ }
----------------
Can you make SymbolTable a member of LinkerScript and directly call addAbsolute here? Then I think you can remove ElfSym<ELFT>::Provide.
http://reviews.llvm.org/D19190
More information about the llvm-commits
mailing list