[PATCH] D19237: ELF: Add +, -, *, / and & to SECTIONS linker script command.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 19 09:53:31 PDT 2016


grimar added a comment.

In http://reviews.llvm.org/D19237#405288, @ruiu wrote:

> If you are familiar with the both algorithms, then what's the reason to choose the one that needs more data types, more internal data structures and more iterations over the same data?


I was not familar with your algorithm when implemented my patch. And after I read about it, reviewed and debugged it, I find my version with more types and more structures much more readable exactly because it has all af that. May be not algorithm itself but at least implementation seems to me much simplier.

In http://reviews.llvm.org/D19237#405288, @ruiu wrote:

> This patch is shorter and simpler.


I don't think so.

I have no arguments to continue. My best one was "I think that my version is better" seems not to work, though I really believe so.
Will you commit your one then ?


http://reviews.llvm.org/D19237





More information about the llvm-commits mailing list