[PATCH] D19237: ELF: Add +, -, *, / and & to SECTIONS linker script command.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 19 09:44:40 PDT 2016


ruiu added a comment.

If you are familiar with the both algorithms, then what's the reason to choose the one that needs more data types, more internal data structures and more iterations over the same data? If I were familiar with an algorithm but not with the other, then that could be a reason to choose one from the other, but I were not, then the choice is obvious. This patch is shorter and simpler. (Note that we could create a reverse-polish expression using the operator precedence parser instead of computing the value of an expression, but we wouldn't want to do that because it is redundant.)


http://reviews.llvm.org/D19237





More information about the llvm-commits mailing list