[PATCH] D19189: Expose the list of available features in MCSubtargetInfo
David Majnemer via llvm-commits
llvm-commits at lists.llvm.org
Sat Apr 16 10:04:55 PDT 2016
On Saturday, April 16, 2016, Johan Engelen via llvm-commits <
llvm-commits at lists.llvm.org> wrote:
> johanengelen added inline comments.
>
> ================
> Comment at: include/llvm/MC/MCSubtargetInfo.h:85
> @@ +84,3 @@
> + /// are enabled for the current CPU.
> + ArrayRef<SubtargetFeatureKV> getProcFeatures() const {
> + return ProcFeatures;
> ----------------
> Should the return type be `const`?
ArrayRefs are immutable, I'd leave it off.
>
>
> http://reviews.llvm.org/D19189
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org <javascript:;>
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160416/72c95c9f/attachment.html>
More information about the llvm-commits
mailing list