<br><br>On Saturday, April 16, 2016, Johan Engelen via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">johanengelen added inline comments.<br>
<br>
================<br>
Comment at: include/llvm/MC/MCSubtargetInfo.h:85<br>
@@ +84,3 @@<br>
+  /// are enabled for the current CPU.<br>
+  ArrayRef<SubtargetFeatureKV> getProcFeatures() const {<br>
+    return ProcFeatures;<br>
----------------<br>
Should the return type be `const`?</blockquote><div><br></div><div>ArrayRefs are immutable, I'd leave it off.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
<a href="http://reviews.llvm.org/D19189" target="_blank">http://reviews.llvm.org/D19189</a><br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="javascript:;" onclick="_e(event, 'cvml', 'llvm-commits@lists.llvm.org')">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote>