[PATCH] D18619: [AArch64] Combine callee-save and local stack SP adjustment instructions.

[Geoff Berry via llvm-commits]

gberry added inline comments.

================
Comment at: lib/Target/AArch64/AArch64FrameLowering.cpp:695
@@ -674,2 +694,3 @@
 
+  assert(!(UseFP && ForceSP) && "ForceSP flag could not be honored");
   assert((isFixed || !RegInfo->needsStackRealignment(MF) || !UseFP) &&
----------------
rengolin wrote:
> Can't you just make:
> 
>     if (ForceSP)
>       UseFP = false;
>     else
>       ...
> 
> ?
I don't think that works in the case where isFixed is true.

================
Comment at: lib/Target/AArch64/AArch64FrameLowering.cpp:814
@@ -791,11 +813,3 @@
       ++i;
   }
 }
----------------
rengolin wrote:
> Would it be possible to get here and (size % 16 != 0)? If so, keeping the assert would be good.
These asserts have just moved to the BumpSP == true part of spillCalleeSavedRegisters/restoreCalleeSavedRegisters


http://reviews.llvm.org/D18619