[PATCH] D18619: [AArch64] Combine callee-save and local stack SP adjustment instructions.

[Renato Golin via llvm-commits]

rengolin added a comment.

Hi Geoff,

I'm not familiar with this part of the code, so I'll leave the full review for Tim, but I think the idea is a good one, and the prologue/epilogue changes in the test look mostly good. Some inline comments, too.

cheers,
--renato


================
Comment at: lib/Target/AArch64/AArch64FrameLowering.cpp:695
@@ -674,2 +694,3 @@
 
+  assert(!(UseFP && ForceSP) && "ForceSP flag could not be honored");
   assert((isFixed || !RegInfo->needsStackRealignment(MF) || !UseFP) &&
----------------
Can't you just make:

    if (ForceSP)
      UseFP = false;
    else
      ...

?

================
Comment at: lib/Target/AArch64/AArch64FrameLowering.cpp:814
@@ -791,11 +813,3 @@
       ++i;
   }
 }
----------------
Would it be possible to get here and (size % 16 != 0)? If so, keeping the assert would be good.


http://reviews.llvm.org/D18619