[PATCH] D19011: [ELF] - Change -t implementation to print which archive members are used.

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: ELF/Driver.cpp:101-102
@@ -100,4 +100,4 @@
   using namespace llvm::sys::fs;
-  if (Config->Verbose || Config->Trace)
+  if (Config->Verbose)
     llvm::outs() << Path << "\n";
   auto MBOrErr = MemoryBuffer::getFile(Path);
----------------
ruiu wrote:
> Is there any reason to keep this code here?
I leaved it intentionally, but the answer on your question should be based on what Verbose should do.
I assumed that it should not behave as -t. For example when we using archives, -t will output only
those members that are used during link. If members are not used - you`ll never see archive name using -t.
Verbose in opposite - always prints any file processed. Including script files by the way, which are not
handled by -t (and that is equal to gold behavior, it does not print script files names).

So my opinion - Verbose is separate option and usefull itself, I would not combine it with -t.

================
Comment at: ELF/SymbolTable.cpp:73
@@ -63,1 +72,3 @@
 
+  if (Config->Trace)
+    llvm::outs() << getFilename(FileP) << "\n";
----------------
ruiu wrote:
> I mean you could make this Config->Trace||Config->Verbose
Please see answer above.


http://reviews.llvm.org/D19011