[PATCH] D19011: [ELF] - Change -t implementation to print which archive members are used.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 12 09:57:01 PDT 2016


ruiu added inline comments.

================
Comment at: ELF/Driver.cpp:101-102
@@ -100,4 +100,4 @@
   using namespace llvm::sys::fs;
-  if (Config->Verbose || Config->Trace)
+  if (Config->Verbose)
     llvm::outs() << Path << "\n";
   auto MBOrErr = MemoryBuffer::getFile(Path);
----------------
Is there any reason to keep this code here?

================
Comment at: ELF/SymbolTable.cpp:73
@@ -63,1 +72,3 @@
 
+  if (Config->Trace)
+    llvm::outs() << getFilename(FileP) << "\n";
----------------
I mean you could make this Config->Trace||Config->Verbose


http://reviews.llvm.org/D19011





More information about the llvm-commits mailing list