[PATCH] D18941: Use the correct scratch wave offset register for shaders.

Nicolai Hähnle via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 12 15:49:51 PDT 2016


nhaehnle added a comment.

In http://reviews.llvm.org/D18941#399137, @nhaehnle wrote:

> This looks like an improvement, but I think it is still incorrect for shaders with non-void returns, where the scratch information may have to be passed through.


As discussed on IRC, it's fine to go ahead with this patch without fixing this, since it isn't a regression. We really need to make sure that non-mono shaders work correctly with spills though.


http://reviews.llvm.org/D18941





More information about the llvm-commits mailing list