[PATCH] D18763: [ThinLTO] Move summary computation from BitcodeWriter to new pass

[Teresa Johnson via llvm-commits]

tejohnson added inline comments.

================
Comment at: include/llvm/Analysis/ModuleSummaryAnalysis.h:32
@@ +31,3 @@
+  const Module *M;
+  std::function<BlockFrequencyInfo *(const Function &F)> BFIFtor;
+
----------------
joker.eph wrote:
> Why do you need a member for `BFIFtor`?
Good point, don't need it. Will clean this up before I submit.

================
Comment at: lib/Analysis/ModuleSummaryAnalysis.cpp:69
@@ +68,3 @@
+  if (!F.hasName())
+    return;
+
----------------
joker.eph wrote:
> I think this is something we want to get rid of right?
Yes but it has to wait until your anonymous function renaming patch is in. 


http://reviews.llvm.org/D18763