[PATCH] D18763: [ThinLTO] Move summary computation from BitcodeWriter to new pass

[Mehdi AMINI via llvm-commits]

joker.eph accepted this revision.
joker.eph added a comment.
This revision is now accepted and ready to land.

LGTM (with two inline comments)


================
Comment at: include/llvm/Analysis/ModuleSummaryAnalysis.h:32
@@ +31,3 @@
+  const Module *M;
+  std::function<BlockFrequencyInfo *(const Function &F)> BFIFtor;
+
----------------
Why do you need a member for `BFIFtor`?

================
Comment at: lib/Analysis/ModuleSummaryAnalysis.cpp:69
@@ +68,3 @@
+  if (!F.hasName())
+    return;
+
----------------
I think this is something we want to get rid of right?


http://reviews.llvm.org/D18763