[PATCH] D18910: [x86] use BMI 'andn' for logic + compare ops
Sanjay Patel via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 8 15:19:42 PDT 2016
spatel added inline comments.
================
Comment at: lib/Target/X86/X86ISelLowering.cpp:14778
@@ +14777,3 @@
+ // now and allow it to be pattern matched into an ANDN.
+ if (!(Subtarget.hasBMI() && isAndn && isLegalAndnType))
+ break;
----------------
kbsmith1 wrote:
> For me this would read better as
> if (!Subtarget.hasBMI() || !isAndn || !isLegalAndnType)
> break;
Yes, that does read better. Thanks!
http://reviews.llvm.org/D18910
More information about the llvm-commits
mailing list