[PATCH] D18910: [x86] use BMI 'andn' for logic + compare ops

[Kevin B. Smith via llvm-commits]

kbsmith1 accepted this revision.
kbsmith1 added a comment.
This revision is now accepted and ready to land.

LGTM. One nit, fix or not at your discretion.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:14778
@@ +14777,3 @@
+      // now and allow it to be pattern matched into an ANDN.
+      if (!(Subtarget.hasBMI() && isAndn && isLegalAndnType))
+        break;
----------------
For me this would read better as
if (!Subtarget.hasBMI() || !isAndn || !isLegalAndnType)
  break;


http://reviews.llvm.org/D18910