[PATCH] D18826: Add auto-exporting of symbols from tools so that plugins work on Windows

[John Brawn via llvm-commits]

john.brawn added inline comments.

================
Comment at: utils/extract_symbols.py:164
@@ +163,3 @@
+        get_symbols = None
+        for exe in tools.keys():
+            try:
----------------
rnk wrote:
> You should probably test the tools in a determinstic order. We also might want to prefer llvm-readobj to dumpbin /symbols. dumpbin is pretty slow.
>From some experiments dumpbin seems to be ~2x the speed of llvm-readobj. Looking at some of the largest libraries I get (building a release build, time in seconds running extract_symbols.py on the library):
| Library | llvm-readobj | dumpbin |
| LLVMCodeGen | 6.9 | 3.2 |
| LLVMCore | 4.6 | 2.1 |
| LLVMAnalysis | 4.6 | 2.5 |
| LLVMScalarOpts | 4.1 | 2.2 |
I do agree on using a deterministic order though.



Repository:
  rL LLVM

http://reviews.llvm.org/D18826