[PATCH] D18826: Add auto-exporting of symbols from tools so that plugins work on Windows

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 6 09:45:01 PDT 2016


rnk added a comment.

This Python script is a wonderful, horrible hack. I submit it to the community as evidence that we should have real API export annotations in our public headers and build with -fvisibility=hidden on Unix. :)


================
Comment at: utils/extract_symbols.py:164
@@ +163,3 @@
+        get_symbols = None
+        for exe in tools.keys():
+            try:
----------------
You should probably test the tools in a determinstic order. We also might want to prefer llvm-readobj to dumpbin /symbols. dumpbin is pretty slow.


Repository:
  rL LLVM

http://reviews.llvm.org/D18826





More information about the llvm-commits mailing list