[PATCH] D17864: [PGO] Promote indirect calls to conditional direct calls with value-profile

[Rong Xu via llvm-commits]

On Wed, Apr 6, 2016 at 3:06 PM, Mehdi AMINI <mehdi.amini at apple.com> wrote:

> joker.eph added inline comments.
>
> ================
> Comment at: lib/Transforms/Instrumentation/IndirectCallPromotion.cpp:535
> @@ +534,3 @@
> +
> +bool processModule(Module &M, bool InLTO) {
> +  if (DisableICP)
> ----------------
> Nice, but should be static considering the name. Alternatively I don't
> mind having it non static if it is called something like
> `promoteIndirectCalls()`
>
Yes. You are absolutely right. I forgot the "static" word. I'll add it back
and also change the name as you suggested.


>
>
> http://reviews.llvm.org/D17864
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160406/a4103e85/attachment.html>