[PATCH] D17864: [PGO] Promote indirect calls to conditional direct calls with value-profile

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 6 15:06:34 PDT 2016


joker.eph added inline comments.

================
Comment at: lib/Transforms/Instrumentation/IndirectCallPromotion.cpp:535
@@ +534,3 @@
+
+bool processModule(Module &M, bool InLTO) {
+  if (DisableICP)
----------------
Nice, but should be static considering the name. Alternatively I don't mind having it non static if it is called something like `promoteIndirectCalls()`


http://reviews.llvm.org/D17864





More information about the llvm-commits mailing list