[PATCH] D18710: code hoisting using GVN

Daniel Berlin via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 4 20:05:53 PDT 2016


We don't want to add flags to control time when we know of better
algorithms that can do it.
Please, let's not add more N^2 algorithms to the compiler just because it
was a bit faster to write. Let's just do it well the first time :)


On Mon, Apr 4, 2016, 3:45 PM Sebastian Pop <sebpop at gmail.com> wrote:

> sebpop removed rL LLVM as the repository for this revision.
> sebpop updated this revision to Diff 52632.
> sebpop added a comment.
>
> Addressed comments from Chad and Danny.
> Added more testcases and a flag to limit the O(n^2) behavior.
>
>
> http://reviews.llvm.org/D18710
>
> Files:
>   llvm/include/llvm/InitializePasses.h
>   llvm/include/llvm/LinkAllPasses.h
>   llvm/include/llvm/Transforms/Scalar.h
>   llvm/include/llvm/Transforms/Scalar/GVN.h
>   llvm/lib/Passes/PassRegistry.def
>   llvm/lib/Transforms/IPO/PassManagerBuilder.cpp
>   llvm/lib/Transforms/Scalar/GVN.cpp
>   llvm/lib/Transforms/Scalar/Scalar.cpp
>   llvm/test/Transforms/GVN/hoist.ll
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160404/8dea44d3/attachment.html>


More information about the llvm-commits mailing list