<div dir="ltr">We don't want to add flags to control time when we know of better algorithms that can do it.<div>Please, let's not add more N^2 algorithms to the compiler just because it was a bit faster to write. Let's just do it well the first time :)</div><div><div><br><br><div class="gmail_quote"><div dir="ltr">On Mon, Apr 4, 2016, 3:45 PM Sebastian Pop <<a href="mailto:sebpop@gmail.com" target="_blank">sebpop@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">sebpop removed rL LLVM as the repository for this revision.<br>
sebpop updated this revision to Diff 52632.<br>
sebpop added a comment.<br>
<br>
Addressed comments from Chad and Danny.<br>
Added more testcases and a flag to limit the O(n^2) behavior.<br>
<br>
<br>
<a href="http://reviews.llvm.org/D18710" rel="noreferrer" target="_blank">http://reviews.llvm.org/D18710</a><br>
<br>
Files:<br>
  llvm/include/llvm/InitializePasses.h<br>
  llvm/include/llvm/LinkAllPasses.h<br>
  llvm/include/llvm/Transforms/Scalar.h<br>
  llvm/include/llvm/Transforms/Scalar/GVN.h<br>
  llvm/lib/Passes/PassRegistry.def<br>
  llvm/lib/Transforms/IPO/PassManagerBuilder.cpp<br>
  llvm/lib/Transforms/Scalar/GVN.cpp<br>
  llvm/lib/Transforms/Scalar/Scalar.cpp<br>
  llvm/test/Transforms/GVN/hoist.ll<br>
<br>
</blockquote></div></div></div></div>