[PATCH] D15302: [Greedy regalloc] Replace analyzeSiblingValues with something new [Part1]

[Wei Mi via llvm-commits]

Thanks for the support of this patch. Looks like Tom's "to objection"
is a typo of "no objection". I will prepare to commit the patch.

Wei.

On Sat, Apr 2, 2016 at 1:38 AM, Chandler Carruth <chandlerc at gmail.com> wrote:
> chandlerc added a subscriber: chandlerc.
> chandlerc added a comment.
>
> It turns out this was ready just in time: we just noticed that r263460 essentially undermines all of the work to avoid PR17409, and we now have widespread superlinear compile times with sanitizers (and possibly other code).
>
> Just wanted to confirm with you Tom that this LGTM, and encourage Wei to go ahead and land it as soon as Tom acks. =D We have a *bunch* of stuff blocked on the compile time issues here.
>
> One minor nit below.
>
>
> ================
> Comment at: lib/CodeGen/InlineSpiller.cpp:57
> @@ +56,3 @@
> +class HoistSpillHelper {
> +  MachineFunction &MF;
> +  LiveIntervals &LIS;
> ----------------
> I get a warning saying this is unused when building with this patched in...
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D15302
>
>
>