[PATCH] D18346: ThinLTO: special handling for LinkOnce functions

[Teresa Johnson via llvm-commits]

tejohnson added a comment.

Submitted comments too early - here is the other one...


================
Comment at: lib/LTO/ThinLTOCodeGenerator.cpp:208
@@ -118,3 +207,3 @@
 
 public:
   ModuleLoader(LLVMContext &Context, StringMap<MemoryBufferRef> &ModuleMap)
----------------
Alias cannot be available_externally (see GlobalAlias::isValidLinkage), so I think for those you while you should do the change of the first copy to weak, the rest need to be left as-is.

Also, it just occurred to me that this is going to be an issue for the aliasee - since aliases must point to a definition, an aliasee cannot become available_externally either. You might have to do some analysis first to see which GV are aliasees and skip the available_externally part for those too. 

You can include these cases in your test.


http://reviews.llvm.org/D18346