[PATCH] D18346: ThinLTO: special handling for LinkOnce functions

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 1 06:46:39 PDT 2016


tejohnson added a comment.

In http://reviews.llvm.org/D18346#389223, @joker.eph wrote:

> Address comment, add a test.


I don't see test, can you try to add again?


================
Comment at: lib/LTO/ThinLTOCodeGenerator.cpp:174
@@ +173,3 @@
+static void ResolveODR(Module &TheModule,
+                             const ModuleSummaryIndex &Index) {
+  for (auto &GV : TheModule) {
----------------
Clang format

================
Comment at: lib/LTO/ThinLTOCodeGenerator.cpp:297
@@ -207,1 +296,3 @@
 
+    // Resolve the LinkOnceODR, trying to turn them into "available_externally"
+    // where possible.
----------------
and WeakODR


http://reviews.llvm.org/D18346





More information about the llvm-commits mailing list