[PATCH] D18548: [Mips] add assembler support for .set arch=octeon

Fri Apr 1 06:14:12 PDT 2016

mpf added inline comments.

================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:5299
@@ -5298,2 +5298,3 @@
           .Case("cnmips", "cnmips")
+          .Case("octeon", "cnmips")
           .Case("r4000", "mips3") // This is an implementation of Mips3.
----------------
petarj wrote:
> Since the goal of this change is only to support ".set arch=octeon" in inline assembly, I am fine with it.
> Having said this, shouldn't we delete the line above, since I do not think that ".set arch=cnmips" is a valid option used anywhere?
In case it was not clear I was not objecting to this patch. I'm merely concerned that the support for octeon may end up inconsistent if nobody finishes the other parts of LLVM that would be affected. The most important part would be to sort out the integrated assembler to set E_MIPS_MACH_OCTEON if someone uses -march=octeon or .module=octeon otherwise an octeon elf will masquerade as a simple mips64r2.


Repository:
  rL LLVM

http://reviews.llvm.org/D18548



