[PATCH] D18548: [Mips] add assembler support for .set arch=octeon
Petar Jovanovic via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 1 05:35:08 PDT 2016
petarj added inline comments.
================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:5299
@@ -5298,2 +5298,3 @@
.Case("cnmips", "cnmips")
+ .Case("octeon", "cnmips")
.Case("r4000", "mips3") // This is an implementation of Mips3.
----------------
Since the goal of this change is only to support ".set arch=octeon" in inline assembly, I am fine with it.
Having said this, shouldn't we delete the line above, since I do not think that ".set arch=cnmips" is a valid option used anywhere?
Repository:
rL LLVM
http://reviews.llvm.org/D18548
More information about the llvm-commits
mailing list