[PATCH] D17606: [PPC64] Bug fix: when enable both sibling-call-opt and shrink-wrapping, the tail call branch instruction might disappear

Chuang-Yu Cheng via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 31 23:52:19 PDT 2016


cycheng closed this revision.
cycheng marked an inline comment as done.
cycheng added a comment.

Committed r265112


================
Comment at: lib/Target/PowerPC/PPCFrameLowering.cpp:1325
@@ +1324,3 @@
+void PPCFrameLowering::createTailCallBranchInstr(MachineBasicBlock &MBB) const {
+  // Same code from emitEpilogue
+  MachineBasicBlock::iterator MBBI = MBB.getFirstTerminator();
----------------
kbarton wrote:
> This comment isn't accurate since you've refactored the code from emitEpilogue into this method. 
> You could probably remove it altogether, but if you want to keep it I could change it to "Originally from emitEpilogue". 
Thanks : )


http://reviews.llvm.org/D17606





More information about the llvm-commits mailing list